fix(platform): properly join URL paths in HttpClientRequest.appendUrl#6021
Merged
tim-smart merged 1 commit intoEffect-TS:mainfrom Feb 3, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 784721d The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
This implements the fix discussed in #5971 - using smart path joining to ensure a slash exists between base URL and appended path, while preserving the "append" semantics (paths starting with Happy to adjust the approach if you'd prefer full URL spec compliance via |
tim-smart
reviewed
Feb 2, 2026
| const request = HttpClientRequest.get("https://api.example.com/v1").pipe( | ||
| HttpClientRequest.appendUrl("") | ||
| ) | ||
| strictEqual(request.url, "https://api.example.com/v1/") |
Contributor
There was a problem hiding this comment.
Suggested change
| strictEqual(request.url, "https://api.example.com/v1/") | |
| strictEqual(request.url, "https://api.example.com/v1") |
Contributor
Author
There was a problem hiding this comment.
Nice catch, updated so empty path returns the request unchanged, thank you!
Previously, appendUrl used simple string concatenation which could produce invalid URLs when the base URL didn't end with a slash and the path didn't start with one (e.g., '/v1' + 'users' = '/v1users'). Now it ensures proper path joining by: 1. Adding a trailing slash to base URL if missing 2. Removing leading slash from path if present This matches the behavior of other HTTP client libraries like axios, got, and ky. Closes Effect-TS#5971
codewithkenzo
force-pushed
the
fix/append-url-path-joining
branch
from
07dd995 to
784721d
Compare
tim-smart
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
HttpClientRequest.appendUrlto properly join URL paths instead of using simple string concatenation.Closes #5971
Problem
The current implementation could produce invalid URLs:
Solution
Ensure proper path joining by:
This matches the behavior of other HTTP client libraries like axios, got, and ky.
Test Cases
https://api.com/v1usershttps://api.com/v1/usershttps://api.com/v1/usershttps://api.com/v1/usershttps://api.com/v1/usershttps://api.com/v1/usershttps://api.com/v1//usershttps://api.com/v1/usersVerification
pnpm check)